fix: use structured YAML parsing for frontmatter and scripts in process_template - #4552
Open
darion-yaphet wants to merge 1 commit into
Open
fix: use structured YAML parsing for frontmatter and scripts in process_template#4552darion-yaphet wants to merge 1 commit into
darion-yaphet wants to merge 1 commit into
Conversation
…ss_template Replace hand-rolled line-by-line scanning and regex matching in IntegrationBase.process_template with yaml.safe_load and yaml.dump. Properly support YAML comments, folded block scalars, and quoted values in command templates while stripping the scripts key cleanly. Add unit tests in tests/integrations/test_base.py to verify structured YAML frontmatter parsing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
scanning loop and regex matching (
script_pattern = re.compile(r"^\s*([A-Za-z0-9_-]+):\s*(.+)$")).|).- It risked accidental matches if
scripts:was referenced inside Markdown body text or code examples.- Stripping
scripts:relied on line indentation checks rather than structured object manipulation.width=float("inf"))
. 4. Adds unit tests intests/integrations/test_base.py` covering YAML comments, quoted script commands, and folded scalar descriptions.Testing
tests/integrations/test_base.py, and drafting commit/PR descriptions.